Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pybind11 to address numpy 1.23 issue #17475

Merged

Conversation

mwoehlke-kitware
Copy link
Contributor

@mwoehlke-kitware mwoehlke-kitware commented Jun 29, 2022

Update to newer pybind11 to address a change in numpy 1.23 that caused some arrays to fail to be converted to Eigen matrices.

See RobotLocomotion/pybind11#58.

Fixes #17457.


This change is Reviewable

@mwoehlke-kitware mwoehlke-kitware added priority: high status: do not review release notes: none This pull request should not be mentioned in the release notes labels Jun 29, 2022
@mwoehlke-kitware
Copy link
Contributor Author

@drake-jenkins-bot mac-big-sur-clang-bazel-experimental-everything-release please
@drake-jenkins-bot mac-monterey-clang-bazel-experimental-everything-release please

Copy link
Contributor

@rpoyner-tri rpoyner-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: needs platform reviewer assigned, needs at least two assigned reviewers (waiting on @mwoehlke-kitware)

@mwoehlke-kitware mwoehlke-kitware added release notes: fix This pull request contains fixes (no new features) and removed release notes: none This pull request should not be mentioned in the release notes labels Jun 29, 2022
Update to newer pybind11 to address a change in numpy 1.23 that caused
some arrays to fail to be converted to Eigen matrices.

See RobotLocomotion/pybind11#58.
@mwoehlke-kitware
Copy link
Contributor Author

@drake-jenkins-bot mac-big-sur-clang-bazel-experimental-release please
@drake-jenkins-bot mac-monterey-clang-bazel-experimental-release please

@mwoehlke-kitware
Copy link
Contributor Author

+@rpoyner-tri for feature review, please.

Copy link
Contributor

@rpoyner-tri rpoyner-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: needs at least two assigned reviewers (waiting on @mwoehlke-kitware)

@rpoyner-tri rpoyner-tri added the status: single reviewer ok https://drake.mit.edu/reviewable.html label Jun 29, 2022
Copy link
Contributor

@rpoyner-tri rpoyner-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+(status: single reviewer ok)

Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignee rpoyner-tri(platform) (waiting on @mwoehlke-kitware)

@jwnimmer-tri jwnimmer-tri marked this pull request as ready for review June 30, 2022 00:30
@jwnimmer-tri jwnimmer-tri merged commit 75d1cde into RobotLocomotion:master Jun 30, 2022
@mwoehlke-kitware mwoehlke-kitware deleted the fix-pybind11-issue branch June 30, 2022 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high release notes: fix This pull request contains fixes (no new features) status: single reviewer ok https://drake.mit.edu/reviewable.html
Development

Successfully merging this pull request may close these issues.

Constructor for LinearSystem fails in python binding test
3 participants