-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pybind11 to address numpy 1.23 issue #17475
Update pybind11 to address numpy 1.23 issue #17475
Conversation
@drake-jenkins-bot mac-big-sur-clang-bazel-experimental-everything-release please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: needs platform reviewer assigned, needs at least two assigned reviewers (waiting on @mwoehlke-kitware)
Update to newer pybind11 to address a change in numpy 1.23 that caused some arrays to fail to be converted to Eigen matrices. See RobotLocomotion/pybind11#58.
2eb36ed
to
469177b
Compare
@drake-jenkins-bot mac-big-sur-clang-bazel-experimental-release please |
+@rpoyner-tri for feature review, please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: needs at least two assigned reviewers (waiting on @mwoehlke-kitware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+(status: single reviewer ok)
Reviewable status: complete! all discussions resolved, LGTM from assignee rpoyner-tri(platform) (waiting on @mwoehlke-kitware)
Update to newer pybind11 to address a change in numpy 1.23 that caused some arrays to fail to be converted to Eigen matrices.
See RobotLocomotion/pybind11#58.
Fixes #17457.
This change is