Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workspace] Fix build recipe for sdformat_internal #17364

Conversation

jwnimmer-tri
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri commented Jun 9, 2022

When the compilation sandbox is disabled (i.e., for coverage builds), it points out a misspelled include path.

Hotfix for #17230.


This change is Reviewable

When the compilation sandbox is disabled (i.e., for coverage builds),
it points out a mis-spelled include path.
@jwnimmer-tri jwnimmer-tri added priority: emergency status: single reviewer ok https://drake.mit.edu/reviewable.html release notes: none This pull request should not be mentioned in the release notes labels Jun 9, 2022
@jwnimmer-tri
Copy link
Collaborator Author

@drake-jenkins-bot linux-focal-gcc-bazel-experimental-coverage please
@drake-jenkins-bot linux-focal-clang-bazel-experimental-coverage please

@jwnimmer-tri jwnimmer-tri marked this pull request as ready for review June 9, 2022 15:11
@jwnimmer-tri
Copy link
Collaborator Author

+@rpoyner-tri for both reviews, please.

Copy link
Contributor

@rpoyner-tri rpoyner-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignee rpoyner-tri(platform) (waiting on @jwnimmer-tri)

@jwnimmer-tri jwnimmer-tri merged commit aac420e into RobotLocomotion:master Jun 9, 2022
@jwnimmer-tri jwnimmer-tri deleted the sdformat-internal-coverage-build-hotfix branch June 9, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: emergency release notes: none This pull request should not be mentioned in the release notes status: single reviewer ok https://drake.mit.edu/reviewable.html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants