Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[workspace] Use sdformat hidden visibility #17230

Merged
merged 1 commit into from
Jun 8, 2022
Merged

[workspace] Use sdformat hidden visibility #17230

merged 1 commit into from
Jun 8, 2022

Commits on Jun 8, 2022

  1. [workspace] Use sdformat and ignition hidden visibility 

    When building C++ code, we should not use -fvisibility=hidden because
it infects all #included code, even the standard library. Instead, we
should wrap the third-party C++ code in a inline hidden namespace.
That way, only the third-party code itself is hidden.

Remove the manually-curated version numbers from ignition builds. We
don't use them for anything, so keeping them in sync is wasted effort.
    @jwnimmer-tri
    jwnimmer-tri committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    0ff7508 View commit details
    Browse the repository at this point in the history