-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jekyll: Do not use strict mode #14672
jekyll: Do not use strict mode #14672
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1.
Reviewable status: needs platform reviewer assigned, needs at least two assigned reviewers
@drake-jenkins-bot linux-focal-unprovisioned-gcc-bazel-experimental-documentation please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+@jamiesnape (retroactive)
+@jwnimmer-tri for platform, please (unless you want to force-merge Jamie)
+(priority: emergency)
Reviewable status: 1 unresolved discussion, LGTM missing from assignee jwnimmer-tri(platform) (waiting on @EricCousineau-TRI and @jwnimmer-tri)
a discussion (no related file):
Working: Requires success from: https://drake-jenkins.csail.mit.edu/job/linux-focal-unprovisioned-gcc-bazel-experimental-documentation/4/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is all ye know on earth.
Reviewed 1 of 1 files at r1.
Reviewable status: 1 unresolved discussion (waiting on @EricCousineau-TRI)
I guess we let the documentation build finish since it is running. |
CI is already noisy enough today that one extra ping is not going to be an issue if someone else merges something. |
I only know of Keats through the Hyperion series; maybe I'll learn more through this campaign :P |
9add043
to
aad31cd
Compare
@drake-jenkins-bot linux-focal-unprovisioned-gcc-bazel-experimental-documentation please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 unresolved discussion (waiting on @EricCousineau-TRI, @jamiesnape, and @jwnimmer-tri)
a discussion (no related file):
Previously, EricCousineau-TRI (Eric Cousineau) wrote…
Working: Requires success from: https://drake-jenkins.csail.mit.edu/job/linux-focal-unprovisioned-gcc-bazel-experimental-documentation/4/
K, I believe this patch will fail in CI. Trying with chroot
via Singularity containerization:
https://gist.github.com/EricCousineau-TRI/ee8a89e0164dab5b58766bc45947bea9
Give me 5 more min. Then I'll give up.
Use `contains` for explicit nested config check for one missing var See: Shopify/liquid#1034 (comment)
aad31cd
to
62e2f45
Compare
contains
for explicit nested config checkThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 unresolved discussion (waiting on @EricCousineau-TRI, @jamiesnape, and @jwnimmer-tri)
a discussion (no related file):
Previously, EricCousineau-TRI (Eric Cousineau) wrote…
K, I believe this patch will fail in CI. Trying with
chroot
via Singularity containerization:
https://gist.github.com/EricCousineau-TRI/ee8a89e0164dab5b58766bc45947bea9Give me 5 more min. Then I'll give up.
K, was able to repro error here: https://drake-cdash.csail.mit.edu/test/129305583
Fixed it in r3, it now serves the website. I'm calling this done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, 1 of 1 files at r3.
Reviewable status: complete! all discussions resolved, LGTM from assignees jwnimmer-tri(platform),jamiesnape
Skipping slow builds. |
Use `contains` for explicit nested config check for one missing var See: Shopify/liquid#1034 (comment)
Use
contains
for explicit nested config check for one missing varSee: Shopify/liquid#1034 (comment)
From failure: https://drake-cdash.csail.mit.edu/test/129053560
This change is