-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
numpy: Should use later version of NumPy #12878
Comments
Focal is going to be 1.17.4 as it stands. If we want to change, ideally it would be to that (on Bionic). |
My opinion would be "some pain" is probably not enough to warrant moving, though. If there is a feature you need that cannot be worked around in a reasonable way, then that would be a reason to change, but you are likely to find that the moving away from apt is going to be very painful, so that needs to be balanced. |
Yes. To the extent we need pip versions instead of apt versions on Ubuntu as runtime dependencies, I think we need I've been thinking about Ubuntu 20.04 timelines a bit. Also relates: #8116 and several other discussions we've had in the past about bleeding edge numpy. |
@EricCousineau-TRI Can you speak to whether 1.17.4 on Focal is sufficiently new to give us the If yes, I'm tempted to say the answer here is just "Use Focal or macOS", and leave Bionic undisturbed, from a conservation-of-effort perspective. |
From looking at the tags including this NumPy commit, yes, it looks like NumPy>=1.17.0 will have So yes, I'm more than happy with that resolution! |
Would you like me to close this now, or wait til we have CI support for Focal? #13102 |
I think my vote is to resolve this as duplicate of #10461 (and possibly pasting some of this consensus there). That issue is the outcome we objectively care about. It's probably worth prototyping the matmul solution once Focal is slightly more blue; within the next two weeks or so, I expect it to get added to Production CI. |
SGTM. Resolution is this comment and the one below: #12878 (comment) Closing as duplicate of #10461, will post there. |
We're feeling some pain from being stuck to Ubuntu 18.04's old version of NumPy (currently 1.13.3, released ~2.5 years ago).
One main issue is supporting #10461, which is useful for things like this:
RussTedrake/underactuated#333
Some potential complications:
\cc @RussTedrake @jwnimmer-tri
The text was updated successfully, but these errors were encountered: