Skip to content

Commit

Permalink
Fix MSVC version error
Browse files Browse the repository at this point in the history
Fix the error message when MSVC is too old; the old error message
claimed to require "14", when it actually requires 19 (a.k.a. VS 2015).
Also, note the Visual Studio release year in the message, which is more
likely to be recognized by users than the internal monotonic version
number.
  • Loading branch information
mwoehlke-kitware committed Jul 11, 2016
1 parent a469fc9 commit df4c5c2
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion cmake/DrakePlatform.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ elseif(CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang" AND CMAKE_CXX_COMPILER_VERSIO
elseif(CMAKE_CXX_COMPILER_ID STREQUAL "Clang" AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS 3.7)
message(FATAL_ERROR "Clang version must be at least 3.7")
elseif(CMAKE_CXX_COMPILER_ID STREQUAL "MSVC" AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS 19)
message(FATAL_ERROR "MSVC version must be at least 14")
message(FATAL_ERROR "MSVC version must be at least 19 (VS 2015)")
endif()

# Set default install prefix
Expand Down
2 changes: 1 addition & 1 deletion drake/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ elseif(CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang" AND CMAKE_CXX_COMPILER_VERSIO
elseif(CMAKE_CXX_COMPILER_ID STREQUAL "Clang" AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS 3.7)
message(FATAL_ERROR "Clang version must be at least 3.7")
elseif(CMAKE_CXX_COMPILER_ID STREQUAL "MSVC" AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS 19)
message(FATAL_ERROR "MSVC version must be at least 14")
message(FATAL_ERROR "MSVC version must be at least 19 (VS 2015)")
endif()

# Create a cache variable that contains the
Expand Down

0 comments on commit df4c5c2

Please sign in to comment.