-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid handing out broken builds to users #74
Comments
Ah, I misunderstood the sequence of events. Drake's CI publishes nightlies, and drake-external-examples tests against them. So it's not a trivial fix. I wonder if drake-external-examples can take over the (I guess really, we should have drake-external-examples in pre-merge anyway, which makes many things better.) |
Or I guess the real problem is that drake-external-examples master assumes that its setup script is compatible with Drake nightlies, which means #61 is the real problem. I guess the Drake nightly should publish an appropriately-compatible setup script itself. |
It is on my TODO list. Until we have API stability and acceptance tests, we are not going to be able to guarantee that each successive night’s packages are compatible with each other. That is not unusual with nightly builds, though. The trouble is that we do not have releases yet. |
Those are good points. |
I think there's nothing left to do here. We have releases, we publish setup scripts, and #61 tracks using the setup scripts for this CI. |
The https://github.com/RobotLocomotion/drake-external-examples/blob/master/drake_cmake_installed/README.md instructions point users to https://drake-packages.csail.mit.edu/drake/nightly/drake-latest-xenial.tar.gz. However, it appears that even if the Nightly CI fails, the package is still uploaded and the "latest" link changed to use it? That means users will see broken nightlies, which seems awful.
Is it easy to change the build to not bump the "latest", or to have a different "latest-passing" or something? Or worst case for now just don't upload anything?
I just had a user try to use the broken nightly and have to ask for help.
The text was updated successfully, but these errors were encountered: