Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[drake_ament_cmake_installed] Failing tests do not show up in CI #336

Open
nicolecheetham opened this issue Oct 30, 2024 · 0 comments
Open

Comments

@nicolecheetham
Copy link
Collaborator

When bugs or errors are introduced in one of the tests, the build output will state test failures occurred but the job in CI will still pass. Failing tests should cause the job to fail and result in the PR having a red X.

Moreover, the ament_cmake_installed runs tests via an executable. This approach does not explicitly mention which tests passed or failed.

--- stderr: drake_ament_cmake_installed
Errors while running CTest
Output from these tests are in: /__w/drake-external-examples/drake-external-examples/drake_ament_cmake_installed/build/drake_ament_cmake_installed/Testing/Temporary/LastTest.log
Use "--rerun-failed --output-on-failure" to re-run the failed cases verbosely.
---
Finished <<< drake_ament_cmake_installed [0.70s]	[ with test failures ]

Full build log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants