Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add librealsense2 packages #230

Merged
merged 3 commits into from
Feb 14, 2022
Merged

Conversation

baszalmstra
Copy link
Contributor

Adds the librealsense2, realsense2-camera, and realsense2-description packages.

@wolfv
Copy link
Member

wolfv commented Feb 14, 2022

ouch, getting hit by a mamba bug :)

@wolfv
Copy link
Member

wolfv commented Feb 14, 2022

let me make release and we retry in a couple hours. sorry

@baszalmstra
Copy link
Contributor Author

Haha no worries!

@baszalmstra
Copy link
Contributor Author

And regarding using librealsense from conda-forge? Can I just add that to the robostack.yaml file? The only downside I see is that it doesn't build for windows, but we can fix that upstream.

@wolfv
Copy link
Member

wolfv commented Feb 14, 2022

Release for mamba in the pipeline, but it'll take ~3 hours to propagate conda-forge/mamba-feedstock#146

@wolfv
Copy link
Member

wolfv commented Feb 14, 2022

I haven't personally tried that package yet but I trust @traversaro a lot :) I am sure if you guys want you can become co-maintainers of the conda-forge feedstock (https://github.com/conda-forge/librealsense-feedstock) to make sure that updates are merged quickly etc.

@traversaro
Copy link
Member

I haven't personally tried that package yet but I trust @traversaro a lot :) I am sure if you guys want you can become co-maintainers of the conda-forge feedstock (https://github.com/conda-forge/librealsense-feedstock) to make sure that updates are merged quickly etc.

Sure! Feel free to open a PR in https://github.com/conda-forge/librealsense-feedstock/pulls if you like.

The general problem of how to handle libraries that are both in ROS buildfarm and in conda-forge is discussed in RoboStack/robostack.github.io#17, and we still do not have a perfect solution, especially for packages that are not marked as _vendor.

@wolfv wolfv merged commit 38bc184 into RoboStack:master Feb 14, 2022
@Tobias-Fischer
Copy link
Collaborator

@Tobias-Fischer
Copy link
Collaborator

See also #131

@wolfv
Copy link
Member

wolfv commented Feb 15, 2022

@Tobias-Fischer I think we can simply remove it again from Windows. It was my fault, I merged too quickly

@baszalmstra
Copy link
Contributor Author

I will make a PR to remove it from windows!

@baszalmstra
Copy link
Contributor Author

Here you go: #233

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants