Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Position Override created to allow position testing #2263

Open
wants to merge 9 commits into
base: ros2
Choose a base branch
from
Open

Conversation

jvogt23
Copy link
Contributor

@jvogt23 jvogt23 commented Jul 1, 2024

Description

Describe your pull request.
Created a way to override a robot's current position for testing purposes.

Associated / Resolved Issue

Resolves # or ClickUp card

Design Documents

Link

Steps to Test

Test Case 1

  1. Step 1 - Run the stack, and under the tab Positions on the right of the main window, set any robot to any position other than auto
  2. Step 2 - Hit the reset button for that robot
  3. Step 3 - Change the goalie number
  4. Step 4 - Set any robot to any position other than auto, then set the goalie number to that robot

Expected result:???

  1. The robot selected should start behaving consistent with the position selected
  2. The robot should go back to whatever its default position is
  3. The robot moving out of "Goalie" status should change to Auto, and the robot selected should become a goalie.
  4. The robot should start by changing its position, then when it becomes the Goalie, the previous goalie should become auto, the UI should allow you to select that robot's position, and the UI should switch the new goalie's override to "Auto" and gray out the combo box so you can no longer change that robot's position.

Key Files to Review

Group 1 - namespace strategy

  • File 1 robot_factory_position.hpp and cpp
  • File 2 overriding_positions.hpp

Group 2 - UI

  • File 3 main_window.cpp
  • File 4 MainWindow.ui

Review Checklist

  • Docstrings: All methods and classes should have the file appropriate docstrings which follow the guidelines in the "Contributing" page of our docs.
  • Remove extra print statements: Any print statements used for debugging should be removed
  • Tag reviewers: Tag some people for review and ping them on Slack

(Optional) Sub-issues (for drafts)

Note: if you find yourself breaking this PR into many smaller features, it may make sense to break up the PR into logical units based on these features.

  • Step 1
  • Step 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants