This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
Fix inconsistent behavior between setState in init and directly assigning to state #232
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Roact 1.x,
setState
is allowed during a component'sinit
method. This change was made to unify all state changes and to further discourage direct mutation of state.However,
getDerivedStateFromProps
remains an ever-present source of finicky corner cases. In the case that users were still assigning directly to state, they would actually lose any derived state that was supposed to be present by the time they rendered.This actually breaks existing components migrating from Roact 0.2.0 to Roact 1.x. This change addresses that incompatibility.
Checklist before submitting:
CHANGELOG.md
Added/updated documentation