This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
Better error message for invalid changed hook name #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZoteTheMighty
suggested changes
Jun 13, 2019
Co-Authored-By: Paul Doyle <[email protected]>
ZoteTheMighty
suggested changes
Jun 14, 2019
There was a problem hiding this comment.
Whoops, looks like the line is too long now 😅
Can you fix this up manually and update the PR?
Other than that, I think this is fine. What do you think, @LPGhatguy ?
LPGhatguy
reviewed
Jun 17, 2019
ZoteTheMighty
approved these changes
Jul 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #206
It seemed like an easy improvement. I made the error message as explicit as I could.
One thing I'd like to be double checked on, is that the protected call won't catch another error and put that message instead. The case I see that could be misleading is if
self._instanceis nil, but is that reasonably possible?Checklist before submitting:
CHANGELOG.md