This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 143
Global debug flag, better error messages #188
Merged
ZoteTheMighty
merged 15 commits into
Roblox:new-reconciler
from
ZoteTheMighty:debug-global
Apr 19, 2019
Merged
Global debug flag, better error messages #188
ZoteTheMighty
merged 15 commits into
Roblox:new-reconciler
from
ZoteTheMighty:debug-global
Apr 19, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZoteTheMighty
force-pushed
the
debug-global
branch
from
April 3, 2019 00:51
7a6d231
to
d21e342
Compare
ZoteTheMighty
requested review from
AmaranthineCodices and
LPGhatguy
and removed request for
AmaranthineCodices
April 3, 2019 22:21
I dunno if this is the approach we want to align on, it seems... okay, but I wonder if it's just a little too messy/intrusive? |
AmaranthineCodices
approved these changes
Apr 4, 2019
Some thoughts on this:
|
I opened rojo-rbx/rojo#160 for the tooling side implications of changes like this that we might be able to port and take advantage of. |
…on the asserts (which is surprising), but we still want hem on for tests
ZoteTheMighty
force-pushed
the
debug-global
branch
from
April 19, 2019 21:25
0fee654
to
4f0b3eb
Compare
LPGhatguy
approved these changes
Apr 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds messages to all asserts. Also adds a convenience method for adjusting assert messages when asserts should only signify internal bugs.
Additionally, adds checks to a global debug flag called_G.ROACT_DEBUG
, which will toggle whether or not we do asserts in our most performance sensitive code paths.Repurposes Config to introduce flagged asserts. Uses mutation internally in Config so that consumers can grab the configuration at require time and refer to updated values after they get set.
So far, speed gains are fairly noticeable in most cases:
Checklist before submitting:
CHANGELOG.md
Added/updated documentation