This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #94; closes #24. Functionally the same as #94, but for the new reconciler instead! Briefly, this adds a new static method to components:
Every time props are updated,
validateProps
will be called with the new props beforeshouldUpdate
andinit
are called.validateProps
returns the same parameters thatassert
expects: a boolean, true if the props passed validation, false if they did not, plus a message explaining why they failed. If the first return value is true, the second value is ignored.This is intended to be used with a type checking library like PropTypes or t.
One question remains about this: should this use GlobalConfig to conditionally disable it? I know we're looking to move away from GlobalConfig, so I'm not sure!
Checklist before submitting: