This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
Allow (and ignore) booleans as children of components #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test case for the behavior? I think it might be time to create a |
|
This should cover the boolean-reification behavior; I'll save the rest of |
|
Look good! The test file looks like it's indented with four spaces instead of tabs though; once you fix that it should be set to merge! |
|
Whoops, fixed now! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #14. It allows for the children table passed to
Roact.createElementto contain boolean values, which will be silently ignored. This enables the use of the patterncondition and Roact.createElement- without this patch, ifconditionisfalse, an error is thrown.