support config dns via network stanza #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lisongmin Looks like the Can you check why the |
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
@lisongmin There was some intermittent issue with |
lisongmin
force-pushed
the
support-dns-via-network-stanza
branch
from
00e68df to
a46f601
Compare
shishir-a412ed
approved these changes
Jan 27, 2021
lisongmin
force-pushed
the
support-dns-via-network-stanza
branch
from
a46f601 to
e0abb30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I added the dns config support in this PR which defined in job-specification/network#dns-parameters.
This PR will resolve following scenario:
nameserver 127.0.0.1in/etc/resolv.confcontainerd-driver, app in task can't resolve the dns.this PR requires building with nomad 1.0 or above, i don't know if it can run with nomad 0.10 or not.
I just comfirm that it can running on nomad 1.0.2.