Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golang, nomad, containerd and nerdctl versions #109

Merged
merged 1 commit into from
Sep 3, 2021

Conversation

shishir-a412ed
Copy link
Contributor

@shishir-a412ed shishir-a412ed commented Sep 2, 2021

This PR:

  • Updates golang to 1.17
  • Updates containerd to 1.5.5
  • Updates nerdctl to 0.11.1
  • Updates nomad to 1.1.4
  • Run nomad in non-dev mode.
  • Fix tests.

/cc @th0m

Signed-off-by: Shishir Mahajan [email protected]

@chuckyz
Copy link
Collaborator

chuckyz commented Sep 2, 2021

@shishir-a412ed why are we -detaching?

@shishir-a412ed
Copy link
Contributor Author

@shishir-a412ed why are we -detaching?

@chuckyz Nomad changed it's default behavior a little bit, and now when you do nomad job run, it right away enters into this monitor mode, which shows you real time progress on your deployment. While it's good when you are running jobs as human, the tests keep waiting on that monitor and eventually fails.

In some tests, job are supposed to just fail so that test can check on the failures. In monitor mode, those tests are not able to progress.

@shishir-a412ed shishir-a412ed merged commit 42df527 into master Sep 3, 2021
@shishir-a412ed shishir-a412ed deleted the version_update branch September 3, 2021 17:14
@github-actions github-actions bot locked and limited conversation to collaborators Sep 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants