Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import index from Matrix to make sure index class definition is always available #21

Merged
merged 1 commit into from
Mar 28, 2022
Merged

Import index from Matrix to make sure index class definition is always available #21

merged 1 commit into from
Mar 28, 2022

Conversation

netique
Copy link
Contributor

@netique netique commented Mar 28, 2022

Should solve #20 and tidyverse/dbplyr#779.

@RobinHankin RobinHankin merged commit 5799d68 into RobinHankin:master Mar 28, 2022
@RobinHankin
Copy link
Owner

RobinHankin commented Mar 28, 2022 •
edited
Loading

thanks for this. I realise that I have used the same device in the onion, jordan, and disordR packages. Right now I am not 100% sure whether I understand the differences between "squash and merge" or "rebase and merge". . . apologies if I use the wrong one. Best wishes, Robin

This was referenced Mar 28, 2022
Closed
Closed
Closed
@seth127 seth127 mentioned this pull request Oct 3, 2022
Closed
@mgirlich mgirlich mentioned this pull request Dec 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@netique @RobinHankin