UMD module output (Will fix #355) #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because distributing JS is so awesome & easy.
This didn't work simply by making the `outputTarget: "umd"` because I had two entries in the webpack config file. One scss and one JS. Which threw webpack for a loop I'm guessing. By breaking the CSS & JS complies into their own webpack files I can now consume dropkick in other applications just fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This didn't work simply by making the
outputTarget: "umd"because Ihad two entries in the webpack config file. One scss and one JS. Which
threw webpack for a loop I'm guessing.
By breaking the CSS & JS complies into their own webpack files I can
now consume dropkick in other applications just fine.