IE9 width fix #269
Merged
IE9 width fix #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -101,7 +102,8 @@ $dk-disabled-color: #BBBBBB !default; | |||
| } | |||
|
|
|||
| .dk-select-options { | |||
| width: 100%; | |||
| min-width: 100%; | |||
There was a problem hiding this comment.
Properties should be ordered background-color, border, border-radius, list-style, margin, max-height, min-width, overflow-x, overflow-y, padding, width, z-index
added 2 commits
February 16, 2015 13:31
Update `.dk-select-options` with new property order.
|
Doh. Forgot to to build, sorry about that. |
|
@aesinv thanks! We'll get this merged and released! |
|
No problem, thanks for the plugin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a project where we are using Dropkick, a defect came through where on IE9 the dropdowns were 17px smaller than the container. After doing some research it looks like IE9 subtracts 17px for the scrollbar, and combined with overflow it unfortunately puts the scrollbar within the container, despite the 17px subtraction.
To fix this without having to stop the width from being dynamic, you just have to change the width from 100% to having a min-width of 100%. To be safe, I also added declarations for
width: auto;andright: 0;. This still forces the UL containing the options to fill the width of the container, even on IE9 when the scrollbar is supposed to take up 17px. The min-width allows the UL to expand passed the "new 100% width" IE9 gives it under these circumstances, and the right: 0; allows it to not expand past the edge of the container.I've been testing this on numerous browsers and devices and it ended up passing QA for our project, so I figured I'd share to help others avoid having to debug this in the future.