Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.5 #201

Merged
merged 26 commits into from
May 13, 2014
Merged

Version 1.5 #201

merged 26 commits into from
May 13, 2014

Conversation

Robdel12
Copy link
Owner

@Robdel12 Robdel12 commented May 7, 2014

No description provided.

rightsaidjames and others added 11 commits February 3, 2014 14:27
Corrected 2 minor spelling mistakes in readme.md
Remove duplicated and unnecessary lines.
I think we can achieve the same goal with less lines of code
### Issues Fixes
- Fix missing string on optionTemplate <#190>
- Provides 'clone' and 'destroy' useful methods <#189>
- Added 'updateField' on 'refresh' methods <#187>
- Added possiblity to apply dropkick on detached DOM elements
<#100>
### Improvements
- Now you can optionally trigger the 'change' event along with the
methods 'reset' or 'refresh'
- Clicking on a selected element doesn't trigger the 'change' event
anymore (Just like the <select> element's default behaviour)
- DropKick was tested and confirmed that works with jQuery 1.7+
- From the bower.json-spec: Do not include minified files.
- Added minimal required css
Issues fixes + Improvements
+ Improved support 'disabled' for both <select> as to <option>
+ Provides a 'disable' method to enable/disable easily
Added "optgroup" support and improved "disabled" suport
@@ -107,7 +111,7 @@
// Hides only dropkick <select> instances
.dk_container select {
position: absolute;
top: -99999em;
// top: -99999em;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead code?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • TODO: Remove

Robert DeLuca and others added 15 commits May 8, 2014 17:07
IE11, FF29, Chrome34, Opera12.16 - Win7
Proposes solution to prevent FOUC + Refactoring code
+ FOUC solution works perfectly in all major browser running in Windows
7, Windows 8 and Ubuntu 14.04
+ Verified also on OSX 10.6 but it performs only a mild difference in
the position of the text
Loading GIST asynchronously we hardly realize FOUC
Loading GIST asynchronously we hardly realize FOUC
Remove the insertion of "dk_fouc" class
Robdel12 pushed a commit that referenced this pull request May 13, 2014
@Robdel12 Robdel12 merged commit 2ab7bff into master May 13, 2014
@Robdel12 Robdel12 deleted the version-1.5 branch May 22, 2014 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants