-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 1.5 #201
Merged
Merged
Version 1.5 #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected 2 minor spelling mistakes in readme.md
Remove duplicated and unnecessary lines.
### Issues Fixes - Fix missing string on optionTemplate <#190> - Provides 'clone' and 'destroy' useful methods <#189> - Added 'updateField' on 'refresh' methods <#187> - Added possiblity to apply dropkick on detached DOM elements <#100> ### Improvements - Now you can optionally trigger the 'change' event along with the methods 'reset' or 'refresh' - Clicking on a selected element doesn't trigger the 'change' event anymore (Just like the <select> element's default behaviour)
- DropKick was tested and confirmed that works with jQuery 1.7+ - From the bower.json-spec: Do not include minified files. - Added minimal required css
Issues fixes + Improvements
+ Improved support 'disabled' for both <select> as to <option> + Provides a 'disable' method to enable/disable easily
Added "optgroup" support and improved "disabled" suport
@@ -107,7 +111,7 @@ | |||
// Hides only dropkick <select> instances | |||
.dk_container select { | |||
position: absolute; | |||
top: -99999em; | |||
// top: -99999em; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dead code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- TODO: Remove
IE11, FF29, Chrome34, Opera12.16 - Win7
Proposes solution to prevent FOUC + Refactoring code
+ FOUC solution works perfectly in all major browser running in Windows 7, Windows 8 and Ubuntu 14.04 + Verified also on OSX 10.6 but it performs only a mild difference in the position of the text
Loading GIST asynchronously we hardly realize FOUC
This reverts commit 045a855.
Loading GIST asynchronously we hardly realize FOUC
Remove the insertion of "dk_fouc" class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.