Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove modal code #281

Merged
merged 2 commits into from
Jan 2, 2019
Merged

Remove modal code #281

merged 2 commits into from
Jan 2, 2019

Conversation

RobbieTheWagner
Copy link
Owner

No description provided.

chuckcarpenter
chuckcarpenter approved these changes Dec 31, 2018
View reviewed changes
Copy link
Contributor

@chuckcarpenter chuckcarpenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but @BrianSipple should probably confirm.

@BrianSipple
Copy link
Contributor

The only thing I think might be missing is some usage of the useModalOverlay setting in the dummy app. (See: 693dd86#diff-b02194543e6fcf5c7caff7b1a2f3d0f4L9)

Other than that, though, LGTM 👍

@RobbieTheWagner
Copy link
Owner Author

@BrianSipple I kept the option here as modal rather than useModalOverlay. The dummy app and tests use the modal functionality.

@RobbieTheWagner RobbieTheWagner merged commit fcd3633 into master Jan 2, 2019
@RobbieTheWagner RobbieTheWagner deleted the remove-modal branch January 2, 2019 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chuckcarpenter chuckcarpenter chuckcarpenter approved these changes

@BrianSipple BrianSipple Awaiting requested review from BrianSipple

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RobbieTheWagner @BrianSipple @chuckcarpenter