Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added PHP/Laravel, Relative Path Support #15

Merged
merged 2 commits into from
Jan 24, 2020

Conversation

DevBodin
Copy link
Contributor

Added optional features primarily aimed at supporting Laravel projects. Added the ability to generate tags in file types other than .html and the option to generate those tags from a directory other than the target file's. (For instance, /public.)

Only thing of concern to the existing package is that because "blade.php" is an extension with a '.' in it, I had to change currentFilePathExtension to currentFileName and used endsWith to make the comparisons. (Which is probably less efficient, but likely has a negligible impact overall.)

(Also Beautify set the indents from 4 spaces to 2.)

Added optional features primarily aimed at supporting Laravel projects. Added the ability to generate tags in file types other than .html and the option to generate those tags from a directory other than the target file's. (For instance, /public.)

Only thing of concern to the existing package is that because "blade.php" is an extension with a '.' in it, I had to change `currentFilePathExtension` to `currentFileName` and used `endsWith` to make the comparisons. (Which is probably less efficient, but likely has a negligible impact overall.)
@DevBodin DevBodin changed the title Added config options for addtl extensions, pathing Added PHP/Laravel, Relative Path Support Jan 15, 2020
@Robbatron
Copy link
Owner

Thanks for all the awesome recommendations! Have never used Laravel but this might give me a reason to try it out! :D

@Robbatron Robbatron merged commit 31e1eb3 into Robbatron:master Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants