Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

performance sketch problem #56

Closed
RobTillaart opened this issue Jul 10, 2024 · 1 comment · Fixed by #57
Closed

performance sketch problem #56

RobTillaart opened this issue Jul 10, 2024 · 1 comment · Fixed by #57
Assignees
@RobTillaart
Labels
bug Something isn't working

Comments

@RobTillaart
Copy link
Owner

https://forum.arduino.cc/t/fram-i2c-robtillaart-wire1-arduino-due/1278579/8

The sketch assumes an int is 2 bytes but this is not the case on DUE, SAMD and many other boards.
Need a fix in the test sketch. Library seems OK, but should be checked if this problem is also in library code.
@RobTillaart RobTillaart added the bug Something isn't working label Jul 10, 2024
@RobTillaart RobTillaart self-assigned this Jul 10, 2024
RobTillaart added a commit that referenced this issue Jul 10, 2024
@RobTillaart
fix #56, performance sketch
18afa98
@RobTillaart
Copy link
Owner Author

Created develop branch,
tested new sketch on DUE (see link above) ==> output looks OK.

@RobTillaart RobTillaart linked a pull request Jul 19, 2024 that will close this issue
Fix #56, performance sketch #57
Merged
RobTillaart added a commit that referenced this issue Jul 19, 2024
@RobTillaart
Fix #56, performance sketch (#57)
480cc48 
- Fix #56, performance sketch
- minor edits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RobTillaart RobTillaart

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #56, performance sketch RobTillaart/FRAM_I2C
1 participant
@RobTillaart