Fix nk_edit_string cursor #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RayLib seems to only measure the spacing *between* glyphs: https://github.com/raysan5/raylib/blob/master/src/rtext.c#L1295 While Nuklear iterates over each glyph from the edit_string when trying to calculate the cursor position calling the width function for each char of the input: https://github.com/vurtun/nuklear/blob/master/src/nuklear_util.c#L1105 That means we need to add one additional spacing when returning the width to compensate for the missing spacing from RayLib.
|
Thanks a lot for these fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RayLib seems to only measure the spacing between glyphs:
https://github.com/raysan5/raylib/blob/master/src/rtext.c#L1295
While Nuklear iterates over each glyph from the edit_string when trying to calculate the cursor position calling the width function for each char of the input:
https://github.com/vurtun/nuklear/blob/master/src/nuklear_util.c#L1105
That means we need to add one additional spacing when returning the width to compensate for the missing spacing from RayLib.
Closes #53