Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduction of the number of constructors for raylib::Rectangle #261

Closed
wants to merge 2 commits into from
Closed

Reduction of the number of constructors for raylib::Rectangle #261

wants to merge 2 commits into from

Conversation

Bigfoot71
Copy link
Contributor

I reduced the number of constructors for raylib::Rectangle using default parameters.

@RobLoach
Copy link
Owner

RobLoach commented Oct 20, 2023

Thanks. I forget why I opted to manually implement these. I think there was an issue with one version of C++ that had conflict between the default parameters and initializer lists. That could no longer be a problem though 🤔

@Bigfoot71
Copy link
Contributor Author

I personally have no problem compiling it with GCC 11.4.0, whether it's with -std=c++11 or -std=c++17. I could perform more thorough tests when I have the time, if you'd like.

@kyomawolf
Copy link
Contributor

Whats up with this PR? Do you know why the build fails?

@RobLoach
Copy link
Owner

If we do take this approach, I'd like to do a few things...

  • Add more tests to make sure the constructors still work properly
  • Apply the same pattern across the rest of the data types

I do remember running into an issue with the initializer list understanding the default parameters, but I'm not sure where/when it happened.

@RobLoach RobLoach closed this Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants