Merge pull request mozilla#9861 from Snuffleupagus/PDFFindController-…

…firstPagePromise Refactor `PDFFindController` to use the 'pagesinit' event, dispatched on the `eventBus`, to resolve the `_firstPagePromise`
Rob--W · Jul 2, 2018 · 42922c9 · 42922c9
2 parents 872c6e4 + 39a1fce
commit 42922c9
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/web/app.js b/web/app.js
@@ -409,6 +409,7 @@ let PDFViewerApplication = {
 
       this.findController = new PDFFindController({
         pdfViewer: this.pdfViewer,
+        eventBus,
       });
       this.findController.onUpdateResultsCount = (matchCount) => {
         if (this.supportsIntegratedFind) {

diff --git a/web/base_viewer.js b/web/base_viewer.js
@@ -479,10 +479,6 @@ class BaseViewer {
       if (this.defaultRenderingQueue) {
         this.update();
       }
-
-      if (this.findController) {
-        this.findController.resolveFirstPage();
-      }
     }).catch((reason) => {
       console.error('Unable to initialize viewer', reason);
     });

diff --git a/web/pdf_find_controller.js b/web/pdf_find_controller.js
@@ -14,6 +14,7 @@
  */
 
 import { createPromiseCapability } from 'pdfjs-lib';
+import { getGlobalEventBus } from './dom_events';
 import { scrollIntoView } from './ui_utils';
 
 const FindState = {
@@ -45,8 +46,9 @@ const CHARACTERS_TO_NORMALIZE = {
  * Provides search functionality to find a given string in a PDF document.
  */
 class PDFFindController {
-  constructor({ pdfViewer, }) {
+  constructor({ pdfViewer, eventBus = getGlobalEventBus(), }) {
     this.pdfViewer = pdfViewer;
+    this.eventBus = eventBus;
 
     this.onUpdateResultsCount = null;
     this.onUpdateState = null;
@@ -82,7 +84,11 @@ class PDFFindController {
     this.findTimeout = null;
 
     this._firstPagePromise = new Promise((resolve) => {
-      this.resolveFirstPage = resolve;
+      const eventBus = this.eventBus;
+      eventBus.on('pagesinit', function onPagesInit() {
+        eventBus.off('pagesinit', onPagesInit);
+        resolve();
+      });
     });
   }