CORSANYWHERE_TARGETWHITELIST allows proxy owner to specify targets that are allowed to be proxied through the server #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proxy owner can supply comma separated list of whitelisted targets that are allowed to be proxied through the server
Server will now reject requests to any target that was not whitelisted by the proxy owner
Rob--W
reviewed
Feb 25, 2022
| @@ -370,6 +371,12 @@ function getHandler(options, proxy) { | |||
| res.end('The origin "' + origin + '" was not whitelisted by the operator of this proxy.'); | |||
| return; | |||
| } | |||
|
|
|||
| if (corsAnywhere.targetWhitelist.length && corsAnywhere.targetWhitelist.indexOf(location.href) === -1) { | |||
There was a problem hiding this comment.
What's the use case for this? This exact match is quite inflexible. If you use cors-anywhere as a library, then you can already enforce this kind of target restriction by comparing req.url.slice(1) with the target whitelist.
To learn more about potential implementation details to improve the design, see #78. See also the review feedback at #111.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.