Always require PHP version for PhpStormStubsSourceStubber - PHP_VERSION_ID as default
#874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kukulich
changed the title
PhpStormStubsSourceStubber - PHP_VERSION_ID as defaultPhpStormStubsSourceStubber - PHP_VERSION_ID as default
asgrim
reviewed
Nov 23, 2021
| @@ -33,6 +33,8 @@ | |||
| use function str_replace; | |||
| use function strtolower; | |||
|
|
|||
| use const PHP_VERSION_ID; | |||
There was a problem hiding this comment.
If I understand correctly, this uses "the PHP version BR is running under", rather than "the PHP version of the code being analysed" as the default? What is the mechanism for overriding this? e.g. if we are using PHP 8.0 to analyse a codebase that runs on PHP 7.4?
There was a problem hiding this comment.
You can always specify the version by yourself: 419c1a7#diff-462651b2de3f83cc239bebc471d6800cebf5893e7258569982934b031c8c422eR169
|
Ok, tests failed because |
…e able to reflect interfaces that exist only in PHP 8.1 stubs
Ocramius
approved these changes
Nov 23, 2021
Ocramius
added
dependencies
|
Thanks for keeping an eye out for the upcoming stubs patch, @kukulich! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's necessary for stubs like: https://github.com/JetBrains/phpstorm-stubs/blob/master/bcmath/bcmath.php#L198-L201
We have to know the version to choose the right parameter.