Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved mutation score #852

Merged
merged 8 commits into from
Nov 14, 2021
Merged

Improved mutation score #852

merged 8 commits into from
Nov 14, 2021

Conversation

kukulich
Copy link
Collaborator

No description provided.

@kukulich kukulich changed the title Mutants Improved mutations score Nov 14, 2021
@kukulich kukulich changed the title Improved mutations score Improved mutation score Nov 14, 2021
@kukulich kukulich force-pushed the mutants branch 2 times, most recently from c11a05d to 7070923 Compare November 14, 2021 13:55
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kukulich kukulich marked this pull request as ready for review November 14, 2021 14:36
@Ocramius
Copy link
Member

🚢 thanks @kukulich!

@Ocramius Ocramius merged commit d6b7d25 into Roave:5.0.x Nov 14, 2021
@kukulich kukulich deleted the mutants branch November 14, 2021 15:57
@kukulich
Copy link
Collaborator Author

@Ocramius

Btw I really don't understand a lot of mutants in PhpStormStubsSourceStubber, eg.

218) /home/runner/work/BetterReflection/BetterReflection/src/SourceLocator/SourceStubber/PhpStormStubsSourceStubber.php:701    [M] IncrementInteger

--- Original
+++ New
@@ @@
     private function parsePhpVersion(string $version) : int
     {
         $parts = array_map('intval', explode('.', $version));
-        return $parts[0] * 10000 + $parts[1] * 100 + ($parts[2] ?? 0);
+        return $parts[0] * 10000 + $parts[2] * 100 + ($parts[2] ?? 0);

There are tests that fail when I apply this change.

@Ocramius
Copy link
Member

There are tests that fail when I apply this change.

Sounds like a coverage / affected tests bug in infection/* 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants