Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved mutation score #841

Merged
merged 20 commits into from
Nov 9, 2021
Merged

Improved mutation score #841

merged 20 commits into from
Nov 9, 2021

Conversation

kukulich
Copy link
Collaborator

@kukulich kukulich commented Nov 9, 2021

No description provided.

@kukulich kukulich force-pushed the mutants branch 2 times, most recently from a86c17a to 2c7483d Compare November 9, 2021 10:58
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢

@kukulich still working on this, or mergeable?

src/NodeCompiler/CompileNodeToValue.php Show resolved Hide resolved
@kukulich
Copy link
Collaborator Author

kukulich commented Nov 9, 2021

@Ocramius Just forcepushed my actual version. I can open another PR when there's anything more to fix.

@kukulich kukulich marked this pull request as ready for review November 9, 2021 12:55
@Ocramius Ocramius merged commit 1bc3bbb into Roave:5.0.x Nov 9, 2021
@Ocramius Ocramius self-assigned this Nov 9, 2021
@Ocramius Ocramius added this to the 5.0.0 milestone Nov 9, 2021
@Ocramius
Copy link
Member

Ocramius commented Nov 9, 2021

Thanks @kukulich!

@kukulich kukulich deleted the mutants branch November 9, 2021 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants