PHP 8.1: Implemented new in initializers

infection.json.dist

@@ -14,6 +14,6 @@
     "mutators": {
         "@default": true
     },
-    "minMsi": 84,
+    "minMsi": 83,
     "minCoveredMsi": 89
 }

src/NodeCompiler/CompileNodeToValue.php

@@ -58,6 +58,10 @@ public function __invoke(Node $node, CompilerContext $context): CompiledValue
                 return $this->getClassConstantValue($node, $constantName, $context);
             }
 
+            if ($node instanceof Node\Expr\New_) {
+                throw Exception\UnableToCompileNode::becauseOfInitializer($context, $node);
+            }
+
             if ($node instanceof Node\Scalar\MagicConst\Dir) {
                 return $this->compileDirConstant($context);
             }

src/NodeCompiler/Exception/UnableToCompileNode.php

@@ -8,6 +8,7 @@
 use PhpParser\Node;
 use Roave\BetterReflection\NodeCompiler\CompilerContext;
 use Roave\BetterReflection\Reflection\ReflectionClass;
+use Roave\BetterReflection\Util\FileHelper;
 
 use function assert;
 use function sprintf;
@@ -70,9 +71,21 @@ public static function becauseOfNotFoundConstantReference(
         return $exception;
     }
 
+    public static function becauseOfInitializer(
+        CompilerContext $context,
+        Node\Expr\New_ $newNode,
+    ): self {
+        return new self(sprintf(
+            'Unable to compile initializer in %s in file %s (line %d)',
+            self::compilerContextToContextDescription($context),
+            self::getFileName($context),
+            $newNode->getLine(),
+        ));
+    }
+
     private static function getFileName(CompilerContext $fetchContext): string
     {
-        return $fetchContext->getFileName() ?? '""';
+        return $fetchContext->getFileName() !== null ? FileHelper::normalizeWindowsPath($fetchContext->getFileName()) : '""';
     }
 
     private static function compilerContextToContextDescription(CompilerContext $fetchContext): string

test/unit/Fixture/NewInInitializers.php

@@ -0,0 +1,14 @@
+<?php
+
+namespace Roave\BetterReflectionTest\Fixture;
+
+use const PHP_VERSION_ID;
+
+const SOME_CONSTANT = 'constant';
+
+class ClassWithNewInInitializers
+{
+    public function methodWithInitializer($parameterWithInitializer = new \ArrayObject(['a', 'b', SOME_CONSTANT, PHP_VERSION_ID, self::class, new \stdClass()]))
+    {
+    }
+}

test/unit/NodeCompiler/CompileNodeToValueTest.php

@@ -24,6 +24,7 @@
 use Roave\BetterReflection\SourceLocator\Type\StringSourceLocator;
 use Roave\BetterReflection\Util\FileHelper;
 use Roave\BetterReflectionTest\BetterReflectionSingleton;
+use Roave\BetterReflectionTest\Fixture\ClassWithNewInInitializers;
 use Roave\BetterReflectionTest\Fixture\MagicConstantsClass;
 use Roave\BetterReflectionTest\Fixture\MagicConstantsTrait;
 
@@ -706,4 +707,23 @@ public function testMagicConstantsInFunction(string $parameterName, mixed $expec
 
         self::assertSame($expectedValue, $parameter->getDefaultValue());
     }
+
+    public function testThrowExceptionWhenValueContainsInitializer(): void
+    {
+        $file = FileHelper::normalizeWindowsPath(realpath(__DIR__ . '/../Fixture/NewInInitializers.php'));
+
+        $this->expectException(UnableToCompileNode::class);
+        $this->expectExceptionMessage(sprintf(
+            'Unable to compile initializer in method %s::methodWithInitializer() in file %s (line 11)',
+            ClassWithNewInInitializers::class,
+            $file,
+        ));
+
+        $reflector = new DefaultReflector(new SingleFileSourceLocator($file, $this->astLocator));
+        $class     = $reflector->reflectClass(ClassWithNewInInitializers::class);
+        $method    = $class->getMethod('methodWithInitializer');
+        $parameter = $method->getParameter('parameterWithInitializer');
+
+        $parameter->getDefaultValue();
+    }
 }

test/unit/NodeCompiler/Exception/UnableToCompileNodeTest.php

@@ -6,6 +6,7 @@
 
 use PhpParser\Node\Expr\ClassConstFetch;
 use PhpParser\Node\Expr\ConstFetch;
+use PhpParser\Node\Expr\New_;
 use PhpParser\Node\Expr\Yield_;
 use PhpParser\Node\Identifier;
 use PhpParser\Node\Name;
@@ -34,6 +35,23 @@ public function testDefaults(): void
         self::assertNull($exception->constantName());
     }
 
+    /** @dataProvider supportedContextTypes */
+    public function testBecauseOfInitializer(CompilerContext $context, string $contextName): void
+    {
+        $exception = UnableToCompileNode::becauseOfInitializer(
+            $context,
+            new New_(new Name('SomeClass')),
+        );
+
+        self::assertSame(
+            sprintf(
+                'Unable to compile initializer in %s in file "" (line -1)',
+                $contextName,
+            ),
+            $exception->getMessage(),
+        );
+    }
+
     /** @dataProvider supportedContextTypes */
     public function testBecauseOfNotFoundConstantReference(CompilerContext $context, string $contextName): void
     {