Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.1: Implemented ReflectionMethod/ReflectionFunction::hasTentativeReturnType() and getTentativeReturnType() #817

Merged
merged 1 commit into from
Oct 14, 2021

Conversation

kukulich
Copy link
Collaborator

@kukulich kukulich commented Oct 13, 2021

It's just very stupid implementation:

  • is user-defined -> is not tentative
  • is internal -> is tentative

May be improved with next release of PHPStorm stubs: JetBrains/phpstorm-stubs#1234

So we may wait...

@kukulich kukulich mentioned this pull request Oct 13, 2021
11 tasks
@kukulich kukulich force-pushed the php81-tentative-return-type branch from 1935787 to b15b243 Compare October 13, 2021 19:49
@kukulich kukulich force-pushed the php81-tentative-return-type branch from b15b243 to 61e5bc0 Compare October 14, 2021 16:06
@Ocramius
Copy link
Member

Ocramius commented Oct 14, 2021

2021.3 seems to be a blood-bath: if this gives us decent compatibility for now, I'd say "roll with it" for now.

@kukulich kukulich marked this pull request as ready for review October 14, 2021 16:09
@Ocramius Ocramius added this to the 5.0.0 milestone Oct 14, 2021
@Ocramius Ocramius self-assigned this Oct 14, 2021
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@Ocramius Ocramius changed the title PHP 8.1: Implemented ReflectionMethod/ReflectionFunction::hasTentativeReturnType() and getTentativeReturnType() PHP 8.1: Implemented ReflectionMethod/ReflectionFunction::hasTentativeReturnType() and getTentativeReturnType() Oct 14, 2021
@Ocramius Ocramius merged commit 331a78f into Roave:5.0.x Oct 14, 2021
@kukulich kukulich deleted the php81-tentative-return-type branch October 14, 2021 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants