Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The resolving of constant name and constant value is now always done in CompileNodeToValue #807

Merged
merged 7 commits into from
Oct 14, 2021
Merged

The resolving of constant name and constant value is now always done in CompileNodeToValue #807

merged 7 commits into from
Oct 14, 2021

Conversation

kukulich
Copy link
Collaborator

@kukulich kukulich commented Oct 12, 2021 •
edited
Loading

The resolving of constant name and constant value is now always done in CompileNodeToValue - it means we don't need to resolve constant name for the first time in ReflectionParameter and for the second time in CompileNodeToValue again.

@kukulich kukulich changed the title Code improvements in Roave\BetterReflection\NodeCompiler Added CompiledValue - value and constant name are resolved in one step Oct 12, 2021
@kukulich kukulich changed the title Added CompiledValue - value and constant name are resolved in one step The resolving of constant name and constant value is now always done in CompileNodeToValue Oct 12, 2021
Ocramius
Ocramius requested changes Oct 14, 2021
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looking very good! Improvements/simplifications totally worth it :)

Some very minor feedback added

src/Reflection/ReflectionProperty.php Show resolved Hide resolved
src/Reflection/ReflectionParameter.php Outdated Show resolved Hide resolved
Ocramius
Ocramius approved these changes Oct 14, 2021
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

Thanks @kukulich!

@Ocramius Ocramius merged commit 82f4d67 into Roave:5.0.x Oct 14, 2021
@Ocramius Ocramius changed the title The resolving of constant name and constant value is now always done in CompileNodeToValue The resolving of constant name and constant value is now always done in CompileNodeToValue Oct 14, 2021
@Ocramius Ocramius self-assigned this Oct 14, 2021
@Ocramius Ocramius added this to the 5.0.0 milestone Oct 14, 2021
@kukulich kukulich deleted the cleanup branch October 14, 2021 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
hacktoberfest-accepted
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kukulich @Ocramius @asgrim