Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ReflectionParameter::isArray() and isCallable() to handle union types #803

Merged
merged 2 commits into from
Oct 12, 2021

Conversation

kukulich
Copy link
Collaborator

@kukulich kukulich commented Oct 12, 2021

Improved version of #792

Fixes #792

@kukulich kukulich changed the title Fixed Reflection::isArray() and isCallable() Fixed ReflectionParameter::isArray() and isCallable() Oct 12, 2021
@kukulich kukulich marked this pull request as draft October 12, 2021 07:38
@kukulich kukulich force-pushed the array-callable branch 2 times, most recently from 5866d6c to bef0b19 Compare October 12, 2021 08:42
@kukulich kukulich marked this pull request as ready for review October 12, 2021 09:05
src/Reflection/ReflectionParameter.php Outdated Show resolved Hide resolved
src/Reflection/ReflectionParameter.php Outdated Show resolved Hide resolved
src/Reflection/ReflectionParameter.php Outdated Show resolved Hide resolved
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 nice! 👍

@Ocramius Ocramius added this to the 5.0.0 milestone Oct 12, 2021
@Ocramius Ocramius self-assigned this Oct 12, 2021
@Ocramius Ocramius changed the title Fixed ReflectionParameter::isArray() and isCallable() Fixed ReflectionParameter::isArray() and isCallable() to handle union types Oct 12, 2021
@Ocramius Ocramius merged commit 313eaf9 into Roave:5.0.x Oct 12, 2021
@kukulich kukulich deleted the array-callable branch October 12, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants