Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promoted properties support #785

Merged
merged 1 commit into from
Sep 23, 2021
Merged

Promoted properties support #785

merged 1 commit into from
Sep 23, 2021

Conversation

kukulich
Copy link
Collaborator

No description provided.

@kukulich kukulich mentioned this pull request Sep 23, 2021
Closed
13 tasks
Ocramius
Ocramius approved these changes Sep 23, 2021
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This turned out to be much cleaner than I though :O

src/Reflection/ReflectionParameter.php Show resolved Hide resolved
@Ocramius Ocramius added this to the 5.0.0 milestone Sep 23, 2021
@Ocramius Ocramius self-assigned this Sep 23, 2021
@Ocramius Ocramius merged commit 6110e22 into Roave:5.0.x Sep 23, 2021
@Ocramius
Copy link
Member

Awesome++

Thanks @kukulich!

@kukulich kukulich deleted the promoted-properties branch September 25, 2021 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
enhancement reflection compatibility
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kukulich @Ocramius