PHP 8.1: Installation and green build #767

kukulich · 2021-09-18T12:32:25Z

No description provided.

.github/workflows/phpunit.yml

composer.json

kukulich · 2021-09-18T20:14:33Z

Btw I think is good to merge the basic PHP 8.1 support because probably there may be new BC breaks so one major BR release can solve them all.

And some PHP 8.1 features can be supported right away (readonly properties) so we can add features one by one. And all new added features can be checked against both PHP versions.

Ocramius · 2021-09-18T20:23:53Z

IMO we need to walk before we run. Would prefer to have mainline having all of 8.0 feature support, then 8.1 support

Ocramius · 2021-09-18T20:24:08Z

We can hold off tagging until then

WyriHaximus · 2021-09-18T20:54:39Z

We can hold off tagging until then

Or release 8.1 support as 5.1?

Ocramius · 2021-09-18T21:00:27Z

Depends if that will lead to further BC breaks - that's why perhaps holding off tagging is a better choice at first :)

kukulich · 2021-09-18T21:38:16Z

This may or may not be BC break: 4bee6ff

kukulich · 2021-09-23T14:37:51Z

@WyriHaximus You can try to implement intersection types here :) You should need new version of https://github.com/nikic/PHP-Parser/releases/tag/v4.13.0

WyriHaximus · 2021-10-04T12:42:00Z

@kukulich You can pick intersection types up from WyriHaximus-labs@7c7af32

kukulich · 2021-10-04T12:45:32Z

@WyriHaximus Done 👍

WyriHaximus · 2021-10-04T14:26:05Z

@kukulich Awesome! Any preference on what I pick up next?

Ocramius

Welp, thought I sent in the review, but my uplink died :D

composer.json

src/Reflection/Adapter/ReflectionClass.php

src/Reflection/Adapter/ReflectionClassConstant.php

src/Reflection/Adapter/ReflectionProperty.php

.github/workflows/phpunit.yml

src/Reflection/ReflectionType.php

src/SourceLocator/SourceStubber/PhpStormStubsSourceStubber.php

src/SourceLocator/SourceStubber/ReflectionSourceStubber.php

kukulich · 2021-10-14T14:31:30Z

@Ocramius Expected result... New asserts (because of 11ef581) lowered the mutation score and the build is red :(

Ocramius · 2021-10-14T14:34:03Z

lowered the mutation

Half as bad

build is red :(

I think it is acceptable to lower the MT thresholds, since we are indeed expanding to cover 2 PHP versions.

If I understand this correctly, we may go back up once we drop PHP 8.0 in a far future (perhaps +6 months)

… versions

kukulich · 2021-10-14T14:49:54Z

1d0914c and we are green again :)

Ocramius

LGTM 🚢

Thanks for investigating this, @kukulich! Massive kudos for the upgrade work and investigation: I'm surprised we got it running on 8.0 and 8.1 after all!

Ocramius · 2021-10-14T14:54:29Z

.github/workflows/phpstan.yml

@@ -32,7 +33,8 @@ jobs:
        with:
          coverage: "none"
          php-version: "${{ matrix.php-version }}"
-          ini-values: memory_limit=-1
+          # No deprecated errors


Yay PHP :|

TBH, we should handle deprecations, but can't deal with them inside third-party tools, obviously.

Ocramius · 2021-10-14T14:55:06Z

UPGRADE.md

@@ -6,6 +6,7 @@ or backwards compatibility (BC) breakages occur.
 ## 5.0.0

 ### BC Breaks
+* All adapters are `final`


BTW, my hope is to generate a whole list of BC breaks through roave/backward-compatibility-check when we get close to tagging this 👍

kukulich marked this pull request as draft September 18, 2021 12:36

kukulich force-pushed the php81 branch from 92128e9 to 218085b Compare September 18, 2021 13:03

Ocramius requested changes Sep 18, 2021

View reviewed changes

.github/workflows/phpunit.yml Show resolved Hide resolved

kukulich force-pushed the php81 branch 2 times, most recently from bc1a962 to eab0e03 Compare September 18, 2021 17:49

Ocramius reviewed Sep 18, 2021

View reviewed changes

composer.json Outdated Show resolved Hide resolved

kukulich force-pushed the php81 branch 2 times, most recently from 537a230 to 60d5a83 Compare September 18, 2021 20:05

kukulich force-pushed the php81 branch 5 times, most recently from 1f9c8f4 to d41ebbd Compare September 23, 2021 14:34

kukulich force-pushed the php81 branch 2 times, most recently from 0aa61f1 to 1d1ece4 Compare September 23, 2021 20:35

kukulich changed the title ~~PHP 8.1 start~~ PHP 8.1 Sep 27, 2021

kukulich force-pushed the php81 branch 2 times, most recently from e258f6d to a418ae0 Compare September 27, 2021 15:45

kukulich mentioned this pull request Oct 3, 2021

PHP 8 compatibility #701

Closed

13 tasks

kukulich force-pushed the php81 branch from a418ae0 to bc28f38 Compare October 4, 2021 12:45

kukulich force-pushed the php81 branch from b8a561a to 2c43ea9 Compare October 14, 2021 12:20

kukulich requested a review from Ocramius October 14, 2021 12:45

Ocramius requested changes Oct 14, 2021

View reviewed changes

kukulich added 13 commits October 14, 2021 15:42

Installable on PHP 8.1

675bee3

Make adapters compatible with PHP 8.1

41a1e8c

Fixed ReflectionSourceStubberTest on PHP 8.1

960f993

Fixed PhpStormSourceStubberTest on PHP 8.1

8cce8d4

Run tests on PHP 8.1

dcf6913

Bump phpstan/phpstan to 0.12.99

9e78c98

Cleanup

235188a

Bump nikic/php-parser to 4.13.0

2ab4eec

Updated locked dependencies

80f0a84

Infection should ignore untestable code

360e212

Mark all adapters as final

9abd6cc

Get rid of PhpParser\Node\ComplexType

11ef581

Run Psalm on PHP 8.1

80ef937

kukulich force-pushed the php81 branch from 2c43ea9 to 7c98267 Compare October 14, 2021 14:06

Run PHPStan on PHP 8.1

ce7ca2e

kukulich force-pushed the php81 branch from 7c98267 to ce7ca2e Compare October 14, 2021 14:13

Ocramius added this to the 5.0.0 milestone Oct 14, 2021

Ocramius added enhancement dependencies Pull requests that update a dependency file labels Oct 14, 2021

Lowered the minimum for mutation score because we now support two PHP…

1d0914c

… versions

Ocramius approved these changes Oct 14, 2021

View reviewed changes

Ocramius self-assigned this Oct 14, 2021

Ocramius merged commit 7bf7481 into Roave:5.0.x Oct 14, 2021

kukulich deleted the php81 branch October 14, 2021 15:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PHP 8.1: Installation and green build #767

PHP 8.1: Installation and green build #767

kukulich commented Sep 18, 2021 •

edited

Loading

kukulich commented Sep 18, 2021

Ocramius commented Sep 18, 2021

Ocramius commented Sep 18, 2021

WyriHaximus commented Sep 18, 2021

Ocramius commented Sep 18, 2021 •

edited

Loading

kukulich commented Sep 18, 2021

kukulich commented Sep 23, 2021

WyriHaximus commented Oct 4, 2021

kukulich commented Oct 4, 2021

WyriHaximus commented Oct 4, 2021

Ocramius left a comment

kukulich commented Oct 14, 2021

Ocramius commented Oct 14, 2021

kukulich commented Oct 14, 2021

Ocramius left a comment

Ocramius Oct 14, 2021

Ocramius Oct 14, 2021

PHP 8.1: Installation and green build #767

PHP 8.1: Installation and green build #767

Conversation

kukulich commented Sep 18, 2021 • edited Loading

kukulich commented Sep 18, 2021

Ocramius commented Sep 18, 2021

Ocramius commented Sep 18, 2021

WyriHaximus commented Sep 18, 2021

Ocramius commented Sep 18, 2021 • edited Loading

kukulich commented Sep 18, 2021

kukulich commented Sep 23, 2021

WyriHaximus commented Oct 4, 2021

kukulich commented Oct 4, 2021

WyriHaximus commented Oct 4, 2021

Ocramius left a comment

Choose a reason for hiding this comment

kukulich commented Oct 14, 2021

Ocramius commented Oct 14, 2021

kukulich commented Oct 14, 2021

Ocramius left a comment

Choose a reason for hiding this comment

Ocramius Oct 14, 2021

Choose a reason for hiding this comment

Ocramius Oct 14, 2021

Choose a reason for hiding this comment

kukulich commented Sep 18, 2021 •

edited

Loading

Ocramius commented Sep 18, 2021 •

edited

Loading