Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trait case sensitivity and aliasing collision fixes #762

Merged
merged 3 commits into from
Sep 17, 2021

Conversation

kukulich
Copy link
Collaborator

@kukulich kukulich commented Sep 17, 2021

Reported by @ondrejmirtes

Fixes #663 and other bugs.

@kukulich kukulich changed the title Trait method rename with wrong case should still work Trait fixes Sep 17, 2021
src/Reflection/ReflectionClass.php Show resolved Hide resolved
src/Reflection/ReflectionClass.php Outdated Show resolved Hide resolved
src/Reflection/ReflectionClass.php Show resolved Hide resolved
test/unit/Reflection/ReflectionClassTest.php Show resolved Hide resolved
@Ocramius Ocramius added this to the 5.0.0 milestone Sep 17, 2021
@Ocramius Ocramius added the bug label Sep 17, 2021
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Ocramius Ocramius self-assigned this Sep 17, 2021
@Ocramius Ocramius changed the title Trait fixes Trait case sensitivity and aliasing collision fixes Sep 17, 2021
@Ocramius Ocramius merged commit 98153d9 into Roave:5.0.x Sep 17, 2021
@kukulich kukulich deleted the trait1 branch September 19, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changed trait method visibility is not taken into account
2 participants