Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coding standard with PHP 8 features #753

Merged
merged 6 commits into from
Sep 16, 2021
Merged

Coding standard with PHP 8 features #753

merged 6 commits into from
Sep 16, 2021

Conversation

kukulich
Copy link
Collaborator

@kukulich kukulich commented Sep 15, 2021 •
edited
Loading

Each sniff enabled in separate commit so it's easy to remove the sniff if not approved.

@kukulich
Copy link
Collaborator Author

@WyriHaximus For you info.

@Ocramius Ocramius added this to the 5.0.0 milestone Sep 15, 2021
@kukulich kukulich mentioned this pull request Sep 15, 2021
Merged
@kukulich kukulich force-pushed the cs branch 3 times, most recently from c5fa816 to a883839 Compare September 15, 2021 22:33
@kukulich kukulich marked this pull request as ready for review September 16, 2021 20:05
@kukulich
Copy link
Collaborator Author

@Ocramius Next one :)

@Ocramius Ocramius self-assigned this Sep 16, 2021
@Ocramius Ocramius merged commit 4f41c61 into Roave:5.0.x Sep 16, 2021
@Ocramius
Copy link
Member

Awesome, thanks! 👍

@kukulich kukulich deleted the cs branch September 17, 2021 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
enhancement
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kukulich @Ocramius