MemoizingParser: Fix parent interface misstype of parse() method

[TomasVotruba]

I believe this is PHP 7.2 feature. The parsing fails otherwise

[TomasVotruba]

Oh, I have dev-master version of PHPParser and this class extends it :/
It has string typehint but this class doesn't.

Any idea how to workaround it?

[Ocramius]

Can't workaround for now: if PHP-Parser has breaking changes, we'll have to adapt ourselves too

[TomasVotruba]

Well, it's only in dev-master and God knows, when that's gonna be tagged.

I'll use https://github.com/cweagans/composer-patches for now

[Ocramius]

@TomasVotruba anything in particular that you rely upon?

[TomasVotruba]

This patch fixed it: rectorphp/rector@2c53ce3#diff-13073b040fd8a4bec22c435bd7392dc9

[Ocramius]

I was actually wondering why you needed PHP-Parser dev-master 🤔

…

On 21 Sep 2017 10:31, "Tomáš Votruba" ***@***.***> wrote: This patch fixed it: ***@***.***#diff- 13073b040fd8a4bec22c435bd7392dc9 <rectorphp/rector@2c53ce3#diff-13073b040fd8a4bec22c435bd7392dc9> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#371 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJakNpfqS3DoCocvtulmdRl6bYD7ToAks5skh7dgaJpZM4Pe4q9> .

[TomasVotruba]

Oh. I need format-preserving AST printer - thanks to that I can refactor the code without making it ugly.

Thanks to that I'll be able to partially upgrade app from Symfony 3.0 to 4.0 while keeping the original formatting.

[Ocramius]

Makes sense, although we won't be able to support both versions of PHP-Parser for now :-\

[TomasVotruba]

No problem, I solved this way I'm fine with 👍