Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update our code for API changes in PHP-Parser #217

Merged
merged 6 commits into from
Dec 24, 2016
Merged

Update our code for API changes in PHP-Parser #217

merged 6 commits into from
Dec 24, 2016

Conversation

asgrim
Copy link
Member

@asgrim asgrim commented Oct 4, 2016 •
edited
Loading

Two things blocking the merge currently:

  • Need nikic/php-parser to be released (requires 3.0.0)
  • Need jeremeamia/superclosure to do a release (I expect it will be 2.3.0) - dev-master has support for php-parser 3.x now
  • Fix blocking issues/failing tests etc.

@asgrim asgrim added the WIP label Oct 4, 2016
@asgrim asgrim self-assigned this Oct 4, 2016
@asgrim
Copy link
Member Author

asgrim commented Oct 11, 2016

BTW this allows us to unblock and work on #202 and #204

@asgrim asgrim force-pushed the update-php-parser-3 branch from 76f81b5 to f9f2fbf Compare November 11, 2016 12:30
@asgrim asgrim force-pushed the update-php-parser-3 branch from 9064887 to 73fb9c5 Compare November 30, 2016 22:30
@asgrim
Copy link
Member Author

asgrim commented Nov 30, 2016

PHP Parser 3.0.0 is now released, still waiting for superclosure to release supporting PHP Parser 3.0.0 I think

@asgrim asgrim mentioned this pull request Nov 30, 2016
Merged
@asgrim
Copy link
Member Author

asgrim commented Dec 3, 2016

For now, going to leave SuperClosure as is here for now and eliminate this external dep in #228

@asgrim asgrim added enhancement and removed WIP labels Dec 3, 2016
@asgrim asgrim mentioned this pull request Dec 5, 2016
Closed
@asgrim asgrim assigned Ocramius and unassigned asgrim Dec 24, 2016
@asgrim asgrim requested a review from Ocramius December 24, 2016 12:40
@asgrim asgrim added this to the 1.3.0 milestone Dec 24, 2016
@asgrim asgrim force-pushed the update-php-parser-3 branch from aec253e to abe448b Compare December 24, 2016 12:41
@asgrim
Copy link
Member Author

asgrim commented Dec 24, 2016

@Ocramius rebased onto master following #227 merge

@Ocramius Ocramius merged commit e0c5f9c into master Dec 24, 2016
@Ocramius
Copy link
Member

👍

@Ocramius Ocramius deleted the update-php-parser-3 branch December 24, 2016 12:51
@asgrim asgrim modified the milestones: 1.3.0, 2.0.0 Mar 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Awaiting requested review from Ocramius

Assignees

@Ocramius Ocramius

Labels
enhancement
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@asgrim @Ocramius