Merge pull request #898 from kukulich/stringable

We should add `Stringable` interface only when it can be reflected
Roave · Dec 5, 2021 · ff18794 · ff18794
2 parents c6c9b85 + 53d433b
commit ff18794
Show file tree

Hide file tree

Showing 2 changed files with 54 additions and 1 deletion.
diff --git a/src/Reflection/ReflectionClass.php b/src/Reflection/ReflectionClass.php
@@ -1112,7 +1112,16 @@ private function addStringableInterface(array $interfaces): array
 
         foreach ($this->node->getMethods() as $methodNode) {
             if ($methodNode->name->toLowerString() === '__tostring') {
-                $interfaces[$stringableClassName] = $this->reflectClassForNamedNode(new Node\Name(Stringable::class));
+                try {
+                    $stringableInterfaceReflection = $this->reflectClassForNamedNode(new Node\Name($stringableClassName));
+
+                    if ($stringableInterfaceReflection->isInternal()) {
+                        $interfaces[$stringableClassName] = $stringableInterfaceReflection;
+                    }
+                } catch (IdentifierNotFound) {
+                    // Stringable interface does not exist on target PHP version
+                }
+
                 break;
             }
         }

diff --git a/test/unit/Reflection/ReflectionClassTest.php b/test/unit/Reflection/ReflectionClassTest.php
@@ -2383,6 +2383,50 @@ public function __toString();
         self::assertArrayHasKey(Stringable::class, $interfaceNotExtendingStringable->getImmediateInterfaces());
     }
 
+    public function testNoStringableInterfaceWhenStringableNotFound(): void
+    {
+        $php = <<<'PHP'
+            <?php
+
+            class NoStringable
+            {
+                public function __toString(): string
+                {
+                }
+            }
+        PHP;
+
+        $reflector = new DefaultReflector(new StringSourceLocator($php, $this->astLocator));
+
+        $noStringable = $reflector->reflectClass('NoStringable');
+
+        self::assertNotContains(Stringable::class, $noStringable->getInterfaceNames());
+    }
+
+    public function testNoStringableInterfaceWhenStringableIsNotInternal(): void
+    {
+        $php = <<<'PHP'
+            <?php
+
+            class Stringable
+            {
+            }
+
+            class NoStringable
+            {
+                public function __toString(): string
+                {
+                }
+            }
+        PHP;
+
+        $reflector = new DefaultReflector(new StringSourceLocator($php, $this->astLocator));
+
+        $noStringable = $reflector->reflectClass('NoStringable');
+
+        self::assertNotContains(Stringable::class, $noStringable->getInterfaceNames());
+    }
+
     public function testHasAllInterfacesWithStringable(): void
     {
         $php = <<<'PHP'