PhpStormStubsSourceStubber should choose the first function definitio…

…n in stubs - PHP works the same way
Roave · Nov 27, 2021 · e312a7b · e312a7b
1 parent 7f53c23
commit e312a7b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 13 deletions.
diff --git a/src/SourceLocator/SourceStubber/PhpStormStubsSourceStubber.php b/src/SourceLocator/SourceStubber/PhpStormStubsSourceStubber.php
@@ -337,7 +337,13 @@ private function parseFile(string $filePath): void
                     $this->modifyFunctionParametersByPhpVersion($functionNode);
                 }
 
-                $this->functionNodes[strtolower($functionName)] = $functionNode;
+                $lowercaseFunctionName = strtolower($functionName);
+
+                if (array_key_exists($lowercaseFunctionName, $this->functionNodes)) {
+                    continue;
+                }
+
+                $this->functionNodes[$lowercaseFunctionName] = $functionNode;
             }
         }
 

diff --git a/test/unit/SourceLocator/SourceStubber/PhpStormStubsSourceStubberTest.php b/test/unit/SourceLocator/SourceStubber/PhpStormStubsSourceStubberTest.php
@@ -319,18 +319,6 @@ public function testInternalFunctions(string $functionName): void
 
         $originalReflection = new CoreReflectionFunction($functionName);
 
-        // There are more versions in PHP
-        if (
-            in_array($functionName, [
-                'setcookie',
-                'setrawcookie',
-                'stream_context_set_option',
-                'strtr',
-            ], true)
-        ) {
-            return;
-        }
-
         $stubbedReflectionParameters = $stubbedReflection->getParameters();
 
         self::assertSame($originalReflection->getNumberOfParameters(), $stubbedReflection->getNumberOfParameters());