Trait method rename with wrong case should still work

Roave · Sep 17, 2021 · 0ba851c · 0ba851c
1 parent c568af2
commit 0ba851c
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 1 deletion.
diff --git a/src/Reflection/ReflectionClass.php b/src/Reflection/ReflectionClass.php
@@ -1068,7 +1068,7 @@ private function methodHash(string $className, string $methodName): string
         return sprintf(
             '%s::%s',
             $className,
-            $methodName,
+            strtolower($methodName),
         );
     }
 

diff --git a/test/unit/Reflection/ReflectionClassTest.php b/test/unit/Reflection/ReflectionClassTest.php
@@ -1882,4 +1882,33 @@ class Foo
         self::assertCount(2, $constants);
         self::assertSame($expectedConstants, $constants);
     }
+
+    public function testTraitRenamingMethodWithWrongCaseShouldStillWork(): void
+    {
+        $php = <<<'PHP'
+            <?php
+            
+            trait MyTrait
+            {
+                protected function myMethod() : void{
+                
+                }
+            }
+            
+            class HelloWorld
+            {
+                use MyTrait {
+                    MyMethod as myRenamedMethod;
+                }
+                
+                public function sayHello(int $date): void
+                {
+                    $this->myRenamedMethod();
+                }
+            }
+        PHP;
+
+        $reflection = (new ClassReflector(new StringSourceLocator($php, $this->astLocator)))->reflect('HelloWorld');
+        self::assertTrue($reflection->hasMethod('myRenamedMethod'));
+    }
 }