Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.0 and PHP 8.1 support, BetterReflection 5.x upgrade #324

Merged
merged 13 commits into from
Dec 6, 2021
Merged

PHP 8.0 and PHP 8.1 support, BetterReflection 5.x upgrade #324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
f9ced23
PHP 8 support and BetterReflection 5.x upgrade
Ocramius Nov 6, 2021
f6739c9
Ensure `IteratorAggregate` is implemented exactly as it is in PHP 8.1…
Ocramius Nov 6, 2021
d6fa8b0
Applied automated CS fixes
Ocramius Nov 6, 2021
0cd7b62
Upgraded to `azjezz/psl`, which should fix `php:8.1.0` compatibility
Ocramius Nov 6, 2021
cfc9528
Prevent installation with incompatible `symfony/process` versions
Ocramius Nov 6, 2021
f8c25b3
Upgraded `roave/better-reflection` to be compatible with https://gith…
Ocramius Dec 5, 2021
ed882dd
Restricting internal types usages to `tests/`, included `psalm/plugin…
Ocramius Dec 5, 2021
12085c4
Implemented covariance/contravariance checks for the new `mixed` and …
Ocramius Dec 5, 2021
06ab4f5
Implemented variance checks for union types
Ocramius Dec 5, 2021
9714b6f
Implemented variance checks for intersection types
Ocramius Dec 5, 2021
ace329f
Added tests for nullability + union types variance checks
Ocramius Dec 5, 2021
19580dd
Upgraded to latest `roave/better-reflection:5.0.x-dev` to include htt…
Ocramius Dec 5, 2021
a8ec81e
Removed all code relying on `ReflectionType#allowsNull()` checks: not…
Ocramius Dec 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/backwards-compatibility.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ jobs:
dependencies:
- "locked"
php-version:
- "7.4"
- "8.0"
- "8.1"
operating-system:
- "ubuntu-latest"

Expand Down
8 changes: 4 additions & 4 deletions bin/roave-backward-compatibility-check.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ static function (string $installationPath) use ($composerIo): Installer {
new PropertyBased\SkipPropertyBasedErrors(new PropertyBased\OnlyPublicPropertyChanged(
new PropertyBased\MultipleChecksOnAProperty(
new PropertyBased\SkipPropertyBasedErrors(new PropertyBased\PropertyBecameInternal()),
new PropertyBased\SkipPropertyBasedErrors(new PropertyBased\PropertyDocumentedTypeChanged()),
new PropertyBased\SkipPropertyBasedErrors(new PropertyBased\PropertyTypeChanged(new TypeIsContravariant(), new TypeIsCovariant())),
new PropertyBased\SkipPropertyBasedErrors(new PropertyBased\PropertyDefaultValueChanged()),
new PropertyBased\SkipPropertyBasedErrors(new PropertyBased\PropertyVisibilityReduced()),
new PropertyBased\SkipPropertyBasedErrors(new PropertyBased\PropertyScopeChanged())
Expand All @@ -123,7 +123,7 @@ static function (string $installationPath) use ($composerIo): Installer {
new PropertyBased\SkipPropertyBasedErrors(new PropertyBased\OnlyProtectedPropertyChanged(
new PropertyBased\MultipleChecksOnAProperty(
new PropertyBased\SkipPropertyBasedErrors(new PropertyBased\PropertyBecameInternal()),
new PropertyBased\SkipPropertyBasedErrors(new PropertyBased\PropertyDocumentedTypeChanged()),
new PropertyBased\SkipPropertyBasedErrors(new PropertyBased\PropertyTypeChanged(new TypeIsContravariant(), new TypeIsCovariant())),
new PropertyBased\SkipPropertyBasedErrors(new PropertyBased\PropertyDefaultValueChanged()),
new PropertyBased\SkipPropertyBasedErrors(new PropertyBased\PropertyVisibilityReduced()),
new PropertyBased\SkipPropertyBasedErrors(new PropertyBased\PropertyScopeChanged())
Expand Down Expand Up @@ -193,7 +193,7 @@ static function (string $installationPath) use ($composerIo): Installer {
new PropertyBased\SkipPropertyBasedErrors(new PropertyBased\OnlyPublicPropertyChanged(
new PropertyBased\MultipleChecksOnAProperty(
new PropertyBased\SkipPropertyBasedErrors(new PropertyBased\PropertyBecameInternal()),
new PropertyBased\SkipPropertyBasedErrors(new PropertyBased\PropertyDocumentedTypeChanged()),
new PropertyBased\SkipPropertyBasedErrors(new PropertyBased\PropertyTypeChanged(new TypeIsContravariant(), new TypeIsCovariant())),
new PropertyBased\SkipPropertyBasedErrors(new PropertyBased\PropertyDefaultValueChanged()),
new PropertyBased\SkipPropertyBasedErrors(new PropertyBased\PropertyVisibilityReduced()),
new PropertyBased\SkipPropertyBasedErrors(new PropertyBased\PropertyScopeChanged())
Expand Down Expand Up @@ -271,7 +271,7 @@ static function (string $installationPath) use ($composerIo): Installer {
new ClassBased\SkipClassBasedErrors(new ClassBased\PropertyChanged(
new PropertyBased\MultipleChecksOnAProperty(
new PropertyBased\SkipPropertyBasedErrors(new PropertyBased\PropertyBecameInternal()),
new PropertyBased\SkipPropertyBasedErrors(new PropertyBased\PropertyDocumentedTypeChanged()),
new PropertyBased\SkipPropertyBasedErrors(new PropertyBased\PropertyTypeChanged(new TypeIsContravariant(), new TypeIsCovariant())),
new PropertyBased\SkipPropertyBasedErrors(new PropertyBased\PropertyDefaultValueChanged()),
new PropertyBased\SkipPropertyBasedErrors(new PropertyBased\PropertyVisibilityReduced()),
new PropertyBased\SkipPropertyBasedErrors(new PropertyBased\PropertyScopeChanged())
Expand Down
17 changes: 12 additions & 5 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@
"name": "roave/backward-compatibility-check",
"description": "Tool to compare two revisions of a public API to check for BC breaks",
"require": {
"php": "^7.4.7",
"php": "~8.0.0 || ~8.1.0",
"ext-json": "*",
"azjezz/psl": "^1.6.1",
"azjezz/psl": "^1.9.1",
"composer/composer": "^2.1.11",
"nikolaposa/version": "^4.1.0",
"ocramius/package-versions": "^2.1.0",
"roave/better-reflection": "^4.12.2",
"ocramius/package-versions": "^2.4.0",
"roave/better-reflection": "5.0.x-dev@DEV",
Ocramius marked this conversation as resolved.
Show resolved Hide resolved
"symfony/console": "^5.3.10"
},
"license": "MIT",
Expand All @@ -26,11 +26,15 @@
"doctrine/coding-standard": "^9.0.0",
"php-standard-library/psalm-plugin": "^1.1.1",
"phpunit/phpunit": "^9.5.10",
"psalm/plugin-phpunit": "^0.16.1",
"roave/infection-static-analysis-plugin": "^1.10",
"roave/security-advisories": "dev-master",
"squizlabs/php_codesniffer": "^3.6.1",
"vimeo/psalm": "^4.12.0"
},
"conflict": {
"symfony/process": "<5.3.7"
},
"autoload": {
"psr-4": {
"Roave\\BackwardCompatibility\\": "src"
Expand All @@ -45,6 +49,9 @@
"bin/roave-backward-compatibility-check"
],
"config": {
"sort-packages": true
"sort-packages": true,
"platform": {
"php": "8.0.99"
Ocramius marked this conversation as resolved.
Show resolved Hide resolved
}
}
}
Loading