bolt-simple-taproot: fix, clarify and add things #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ script layout and readability
fix and make scripts smaller
We'll just re-use the funding key instead. Alternatively, we could use the _other_ party's key here.
Doesn't add anything atm, so might as well drop it.
This also adds the new partial signature encoding which uses the final nonce which is needed for final signature combination.
antonilol
force-pushed
the
taproot-chans
branch
from
1905dce
to
24b9f7d
Compare
|
rebased (2 days ago) on your most recent commit in lightning#995, can you review my changes? |
Roasbeef
requested changes
Nov 11, 2022
bolt-simple-taproot.md
Outdated
|
|
||
| The to remote output has the following form: | ||
|
|
||
| * `OP_1 to_remote_output_key` | ||
| * where: | ||
| * `to_remote_output_key = combined_funding_key + tagged_hash("TapTweak", combined_funding_key || to_remote_script_root)` | ||
| * `to_remote_output_key = revocationpubkey + tagged_hash("TapTweak", revocationpubkey || to_remote_script_root)` |
There was a problem hiding this comment.
This'll end up breaking the deterministic nature of the output, which is important for things like SCB recovery. If this changes every state, then a party that has lost data (but knows the funding keys) can't find it on chain. As is, they just needs this static information that never changes and they can detect this output. For the history here, see the static_remote_key feature bit/saga.
There was a problem hiding this comment.
good point, reverting this change
antonilol
force-pushed
the
taproot-chans
branch
from
24b9f7d
to
811dab2
Compare
In this commit, we build off the prior JIT nonce proposal modifying the
following:
* The funding flow returns to being symmetric. Both `open_channel` and
`accept_channel` carry nonces.
* The `shutdown` message once again transmit a nonce that'll be used
by both sides to sign the shutdown transaction. A symmetric nonce
approach is used here as both sides already know what the other will
use for their nonce, and there's only a single message to sign.
* The `closing_signed` message now only carries a 32-byte
`partial_sig` value, as the nonces has already been transmitted
ahead of time. Additionally, the existing "negotiation" feature has
been done away with. Cooperative close will now always succeed after
a single round, as the initiator is the only that ultimately pays
fees.
bolt-simple-taproot: make funding symmetric, add new type for shutdown
- clarify `output_key_y_parity` - add usage of htlc keys for anchors in case no balance output exists - fix `2:` -> `2.` markdown ordered list - clarify `SIGHASH_SINGLE|SIGHASH_ANYONECANPAY` usage in HTLC second level txs
antonilol
force-pushed
the
taproot-chans
branch
from
811dab2
to
b7485d3
Compare
Roasbeef
force-pushed
the
simple-taproot-chans
branch
from
e95e7ac
to
e25132d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lightning#995
i read through the document again and found many things that i would change.
notable changes:
use of revocation key in theto_remotescript (explanation in the document and in this comment)one question:is this correct? (lines +844, +845)