Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corousel Uniformity #163

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

AntonioRdzNav
Copy link
Member

This PR contains the necessary changes to replace the carousel customed implementations to instead use the Material-UI library.

The only carousel that was not using the Material-UI library was the carousel of the 'About' tab.

I did my best to keep the style exactly as it used to look with the previous implementation, the only UI-wise difference that can be identified is that the transition of images is now smoother and has an animation (provided by the library itself).

image

@AntonioRdzNav AntonioRdzNav self-assigned this Oct 13, 2021
@AntonioRdzNav AntonioRdzNav linked an issue Oct 13, 2021 that may be closed by this pull request
1 task
Copy link

@JamirLeal JamirLeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you Toño! I just left a minor comment

height: 100vh;
}

/* Full-Size styles */

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding the comments!

justify-content: center;
align-items: center;
}
.small-size-slide>h1{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the code standards could you please add a space before and after all the "{" or ">" appearings?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Hot fixes] Hot Fixes General
2 participants