Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forcing protractor 3.1.1 to be used due to issues with 3.2 #93

Closed
wants to merge 1 commit into from

Conversation

stulees
Copy link
Contributor

@stulees stulees commented Mar 18, 2016

@stulees
Copy link
Contributor Author

stulees commented Mar 18, 2016

@rodrigopavezi @alex-deaconu Please review, this should fix our build timeout issues on CCI when tests are being run.

@rodrigopavezi
Copy link
Contributor

@stulees looks good 👍 cheers

@alex-deaconu
Copy link
Contributor

@stulees just ran into the same issue. Here's my version of the fix: https://github.com/Rise-Vision/widget-tester/compare/chore/update-protractor?expand=1.

Basically, I'm updating the gulp-protractor version which automatically forces newer Protractor to be used. This fixes the Error: Cannot find module 'protractor' issue.

@rodrigopavezi FYI. Thoughts? Thanks.

@stulees
Copy link
Contributor Author

stulees commented Mar 18, 2016

@alex-deaconu From what I can tell the problem is with protractor latest version 3.2 itself which is the version getting installed by widget-tester in CCI builds. There's been a couple issues logged against it in the last few hours, the main one being this one - angular/protractor#3034 which looks to be why protractor can't be found when our tests get run in CCI.

@alex-deaconu
Copy link
Contributor

@stulees gulp-protractor 2.0 forces protractor:~3.1.1 version by default: https://github.com/mllrsohn/gulp-protractor/blob/master/package.json.

This way we stay up to date with library versions.

Thanks.

@stulees
Copy link
Contributor Author

stulees commented Mar 18, 2016

@alex-deaconu Ah I see now that gulp-protractor 0.0.11 specifies "*" as the protractor version https://goo.gl/OJBOmr . Good call on the change.

I'll close this PR, can you open a PR for your branch fix? Cheers

@stulees stulees closed this Mar 18, 2016
@stulees stulees deleted the chore/protractor-version branch March 18, 2016 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants