ensure abort() is passed an Exception #722
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently, Exception#cause does nothing to ensure that there is actually an inner or original Exception instance, and this leads to an unhelpful error message about expecting String and getting Nil when rescue in `ChefMutex#synchronize()` finally calls `abort()`. In my case, the error I needed was that the constraints in the environment were untenable because I hadn't run `berks upload`. I tried to write a spec for this, but wasn't able to assert that the mutex should receive abort and that the argument should be a RuntimeError with message 'foo'. It would either barf on me for having an error, hang, or never receive any calls to abort.
|
Nice catch, thanks for this! 👍 from me. |
|
This looks good, 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, Exception#cause does nothing to ensure that there is actually an
inner or original Exception instance, and this leads to an unhelpful error
message about expecting String and getting Nil when rescue in
ChefMutex#synchronize()finally callsabort().In my case, the error I needed was that the constraints in the environment
were untenable because I hadn't run
berks upload.I tried to write a spec for this, but wasn't able to assert that the mutex
should receive abort and that the argument should be a RuntimeError with
message 'foo'. It would either barf on me for having an error, hang, or never
receive any calls to abort.