Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[608] Migrate Documentation to GitHub Pages #641

Merged
merged 16 commits into from
Nov 14, 2024

Conversation

hk21702
Copy link
Collaborator

@hk21702 hk21702 commented Oct 14, 2024

Partially implements #608. Migrates documentation to use GitHub pages using the "Just the Docs" Jekyll theme. Also, includes a better formatted README file.

All information from the old wiki has been migrated. Assets have not been updated. Some content has been improved and or added, but most is the same from the old wiki.

Some pages were broken up into sub-pages to take better advantage of the flexibility that GitHub pages gives us.
Everything other than the 404 page is written in markdown.

Wiki link within RimSort has not been updated in case there is an issue with first deployment.

image
image

@hk21702 hk21702 added the documentation 📚 related to Docs like wiki page README, changelog label Oct 14, 2024
@hk21702 hk21702 self-assigned this Oct 14, 2024
@github-actions github-actions bot added the DevOps 💻 Related to development automation, auto building, auto actions, and other CI/CD things label Oct 14, 2024
@hk21702 hk21702 force-pushed the jekyll-docs-migration branch 2 times, most recently from c55554e to cca9950 Compare October 14, 2024 01:57
@hk21702 hk21702 force-pushed the jekyll-docs-migration branch 2 times, most recently from 4924658 to 753d9ea Compare October 14, 2024 02:20
@hk21702 hk21702 force-pushed the jekyll-docs-migration branch from 753d9ea to 928a70a Compare October 14, 2024 14:44
Copy link
Collaborator

@Patryk-Malinowski Patryk-Malinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about removing the table of contents for User and Dev Guide? And I only mean the table in the in the index.md files. I don't know how full these will get but I still imagine it will mainly be linking to other pages and would look cleaner and less cluttered without the TOC?

image

image

I feel like this gets worse the more links are added and can imagine a new user opening the page and being confused/overwhelmed? This can also maybe give the impression of the TOC links being different from the above links due to some differences in naming? Like Using the Rule Editor and Rule Editor could make a user think they are different links at first?

image

#########################################

Would it be a good idea to move the External Metadata away from basic usage?
In the image below, maybe at the end of that part say something like 'to learn more about Community rules...' etc. with a link so the users can read up about the steam workshop and community rules databases?
image

However at the same time I guess we want to highlight why they should use them... so maybe a way of saying 'we strongly recommend you look at this link and download/enable this'.

Or maybe keep a short and really simple paragraph on each in Basic Usage explaining what they are used for and that we strongly recommend users set it up with a link leading to the steps on how to do this?

And we can keep more detailed information away from Basic Usage if they want to give that a read?

@Patryk-Malinowski
Copy link
Collaborator

Oh and otherwise I think it looks great. Looking forward to when this gets merged :)

@hk21702
Copy link
Collaborator Author

hk21702 commented Nov 13, 2024

What do you think about removing the table of contents for User and Dev Guide? And I only mean the table in the in the index.md files. I don't know how full these will get but I still imagine it will mainly be linking to other pages and would look cleaner and less cluttered without the TOC?

I initially wanted to do this, but as far as I can tell, you have to have a parent page when you categorize stuff like this. I could be wrong though and I'll double check.

@hk21702
Copy link
Collaborator Author

hk21702 commented Nov 13, 2024

Would it be a good idea to move the External Metadata away from basic usage?
In the image below, maybe at the end of that part say something like 'to learn more about Community rules...' etc. with a link so the users can read up about the steam workshop and community rules databases?

We can. I'll look at changing it in this pr, but the goal was to just migrate existing stuff from the old wiki.

@Patryk-Malinowski
Copy link
Collaborator

I initially wanted to do this, but as far as I can tell, you have to have a parent page when you categorize stuff like this. I could be wrong though and I'll double check.

Just to make sure, I meant keep the parent/index.md files but remove TOC. I think I just used has_toc: false at the top of index.md to remove the TOC.

@hk21702
Copy link
Collaborator Author

hk21702 commented Nov 13, 2024

Just to make sure, I meant keep the parent/index.md files but remove TOC. I think I just used has_toc: false at the top of index.md to remove the TOC.

Oh sorry, yeah can do that. Weird... for some reason that wasn't rendering at all for me on my side.

@hk21702
Copy link
Collaborator Author

hk21702 commented Nov 13, 2024

Would it be a good idea to move the External Metadata away from basic usage?
In the image below, maybe at the end of that part say something like 'to learn more about Community rules...' etc. with a link so the users can read up about the steam workshop and community rules databases?

We can. I'll look at changing it in this pr, but the goal was to just migrate existing stuff from the old wiki.

Looking at this again, I will just simplify it a little. Moving it out entirely is a little overkill as we already have a databases page. But, with the new format, it can be organized a lot better to make it easier on the eyes.

@hk21702
Copy link
Collaborator Author

hk21702 commented Nov 13, 2024

Just to make sure, I meant keep the parent/index.md files but remove TOC. I think I just used has_toc: false at the top of index.md to remove the TOC.

Oh sorry, yeah can do that. Weird... for some reason that wasn't rendering at all for me on my side.

Honestly, the automatic rendering you see here should be preferred, as it is automatic. So, instead, I'm going to axe the manual stuff I made back when I couldn't get it to show up on its own.

@hk21702 hk21702 force-pushed the jekyll-docs-migration branch from 0c7958a to 42be893 Compare November 13, 2024 07:05
@hk21702
Copy link
Collaborator Author

hk21702 commented Nov 13, 2024

I updated a bit more content, but for this PR I'm going to pause on any content updates unless it is critical.

@hk21702 hk21702 linked an issue Nov 13, 2024 that may be closed by this pull request
11 tasks
Copy link
Collaborator

@Patryk-Malinowski Patryk-Malinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the manual links and just leaving the generated TOC was definitely the right call. Will save us the hassle of remembering and adding new links etc. as more subpages are added.

The external metadata part looks great too, I definitely think it is easier to digest now.

@Patryk-Malinowski
Copy link
Collaborator

We can. I'll look at changing it in this pr, but the goal was to just migrate existing stuff from the old wiki.

Yeah sorry that might have been going past the 'structure review'. Just wanted to mention it. Obviously once we are using this we can start updating the content and adding more etc.

@hk21702 hk21702 merged commit 831d3eb into RimSort:main Nov 14, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DevOps 💻 Related to development automation, auto building, auto actions, and other CI/CD things documentation 📚 related to Docs like wiki page README, changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion: Update Wiki
2 participants